Skip to content

Conversation

@yaira2
Copy link
Member

@yaira2 yaira2 commented Jul 22, 2024

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

  • Closes #

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Opened Files ...
  2. ...

@yaira2 yaira2 added the ready for review Pull requests that are ready for review label Jul 22, 2024
@yaira2 yaira2 requested a review from hishitetsu July 22, 2024 16:03
@yaira2 yaira2 changed the title Code Quality: Fallback to "C:\" if var doesn't work Code Quality: Fallback to "C:\" when var doesn't work Jul 22, 2024
@yaira2 yaira2 closed this Jul 22, 2024
@yaira2 yaira2 deleted the ya/SystemDrivePath branch July 22, 2024 16:39
@yaira2 yaira2 restored the ya/SystemDrivePath branch July 23, 2024 02:58
@yaira2 yaira2 reopened this Jul 23, 2024
@yaira2 yaira2 requested a review from hishitetsu July 23, 2024 05:37
@yaira2 yaira2 requested a review from hishitetsu July 23, 2024 16:07
Co-authored-by: hishitetsu <66369541+hishitetsu@users.noreply.github.com>
Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit 277ccb0 into main Jul 24, 2024
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Jul 24, 2024
@yaira2 yaira2 deleted the ya/SystemDrivePath branch July 24, 2024 00:44
yaira2 added a commit that referenced this pull request Jul 24, 2024
yaira2 added a commit that referenced this pull request Jul 24, 2024
yaira2 added a commit that referenced this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants